Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show user profile widget when logged in (incl. on permission denied error page) #1705

Merged

Conversation

rfontanarosa
Copy link
Collaborator

closes #1704

@rfontanarosa rfontanarosa requested a review from gino-m April 8, 2024 17:54
@rfontanarosa rfontanarosa changed the title Ground- Current User Widget always visible if user is logged in Ground Current User Widget always visible if user is logged in Apr 8, 2024
@rfontanarosa rfontanarosa self-assigned this Apr 8, 2024
@rfontanarosa rfontanarosa changed the title Ground Current User Widget always visible if user is logged in Always show user profile widget when logged in (incl. on permission denied error page) Apr 8, 2024
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this affect when the user profile widget is shown? Looks to me like that part was unchanged?

@rfontanarosa
Copy link
Collaborator Author

because the condition is inside the user widget (<div *ngIf="auth.getUser$() | async as user">).

the main problem was that the widget was under canManage condition.

@rfontanarosa rfontanarosa requested a review from gino-m April 9, 2024 09:00
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, the diff wasn't too clear, thanks for clarifying.

@gino-m gino-m merged commit 2655dfa into master Apr 9, 2024
5 checks passed
@gino-m gino-m deleted the rfontanarosa/1704/bug-user-icon-always-visible-if-logged-in branch April 9, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] User icon is not always visible when the user is logged in
2 participants