Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save task changes into proto format #1902

Conversation

rfontanarosa
Copy link
Collaborator

@rfontanarosa rfontanarosa commented Jul 12, 2024

towards #1884
closes #1899

@rfontanarosa rfontanarosa requested a review from gino-m July 12, 2024 12:55
@nwkotto nwkotto self-requested a review July 12, 2024 17:07
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, thank you!

web/src/app/converters/proto-model-converter.ts Outdated Show resolved Hide resolved
web/src/app/converters/proto-model-converter.ts Outdated Show resolved Hide resolved
@rfontanarosa rfontanarosa self-assigned this Jul 15, 2024
@rfontanarosa rfontanarosa requested a review from gino-m July 15, 2024 10:53
@rfontanarosa rfontanarosa requested a review from gino-m July 15, 2024 12:44
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@rfontanarosa rfontanarosa merged commit 32dbac4 into master Jul 15, 2024
5 checks passed
@rfontanarosa rfontanarosa deleted the rfontanarosa/1884/edit-survey-publish-changes-doesnt-write-survey-in-new-format branch July 15, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultipleChoiceSelection Condition Proto is missing task ID field
2 participants