Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13: [Form editor] Drag to reorder form fields #90

Merged
merged 1 commit into from
Jul 19, 2019
Merged

#13: [Form editor] Drag to reorder form fields #90

merged 1 commit into from
Jul 19, 2019

Conversation

DaoyuT
Copy link
Contributor

@DaoyuT DaoyuT commented Jul 15, 2019 •
edited
Loading

Need help:

  • drag reorder works and saves the data, but row shows blank when dragging, how to debug? css below
  • npm install -s https -> http, keep?

TODO:

  • make handle prettier
  • css: change row to be on top of table

@DaoyuT DaoyuT requested a review from gino-m July 15, 2019 22:31
@DaoyuT DaoyuT mentioned this pull request Jul 15, 2019
Closed
@DaoyuT DaoyuT assigned DaoyuT and unassigned DaoyuT Jul 15, 2019
gino-m
gino-m requested changes Jul 17, 2019
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A few suggestion/comments.

web/package-lock.json Outdated Show resolved Hide resolved
web/src/components/gnd-feature-type-editor/gnd-form-editor.js Outdated Show resolved Hide resolved
web/src/components/gnd-feature-type-editor/gnd-form-editor.js Outdated Show resolved Hide resolved
web/src/components/gnd-feature-type-editor/gnd-form-editor.js Outdated Show resolved Hide resolved
@DaoyuT DaoyuT force-pushed the master branch 3 times, most recently from 3d9207e to 39ed451 Compare July 18, 2019 20:44
gino-m
gino-m approved these changes Jul 19, 2019
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! So neat how smooth the UI is for this. Thanks!

@DaoyuT DaoyuT merged commit bca25b7 into google:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gino-m gino-m gino-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaoyuT @gino-m