Skip to content

Commit

Permalink
Remove unused package-private FieldAttributes methods (#2162)
Browse files Browse the repository at this point in the history
  • Loading branch information
Marcono1234 authored Jul 29, 2022
1 parent 2deb209 commit 6d2557d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 29 deletions.
25 changes: 3 additions & 22 deletions gson/src/main/java/com/google/gson/FieldAttributes.java
Original file line number Diff line number Diff line change
Expand Up @@ -135,27 +135,8 @@ public boolean hasModifier(int modifier) {
return (field.getModifiers() & modifier) != 0;
}

/**
* Returns the value of the field represented by this {@code Field}, on
* the specified object. The value is automatically wrapped in an
* object if it has a primitive type.
*
* @return the value of the represented field in object
* {@code obj}; primitive values are wrapped in an appropriate
* object before being returned
* @throws IllegalAccessException
* @throws IllegalArgumentException
*/
Object get(Object instance) throws IllegalAccessException {
return field.get(instance);
}

/**
* This is exposed internally only for the removing synthetic fields from the JSON output.
*
* @return true if the field is synthetic; otherwise false
*/
boolean isSynthetic() {
return field.isSynthetic();
@Override
public String toString() {
return field.toString();
}
}
8 changes: 1 addition & 7 deletions gson/src/test/java/com/google/gson/FieldAttributesTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@
package com.google.gson;

import com.google.gson.reflect.TypeToken;

import junit.framework.TestCase;

import java.lang.reflect.Modifier;
import java.lang.reflect.Type;
import java.util.List;
import junit.framework.TestCase;

/**
* Unit tests for the {@link FieldAttributes} class.
Expand Down Expand Up @@ -62,10 +60,6 @@ public void testModifiers() throws Exception {
assertTrue(fieldAttributes.hasModifier(Modifier.TRANSIENT));
}

public void testIsSynthetic() throws Exception {
assertFalse(fieldAttributes.isSynthetic());
}

public void testName() throws Exception {
assertEquals("bar", fieldAttributes.getName());
}
Expand Down

0 comments on commit 6d2557d

Please sign in to comment.