feat: use typescript 2.7.1 and esModuleInterop #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 10 10
Lines 327 327
Branches 19 19
=======================================
Hits 316 316
Misses 11 11
Continue to review full report at Codecov.
|
jinwoo
force-pushed
the
esmoduleinterop
branch
from
7f19c1f
to
90942cd
Compare
|
Typescript 2.7.x would be a semver major change; so let's no land this now. It would be okay landing this onto a |
[BREAKING CHANGE] This PR is both for the generated `package.json` and `gts` itself. TypeScript 2.7.1 added `--esModuleInterop` for better ES module support. And for that, we need to turn on `allowSyntheticDefaultImports` too. Also `tslint` must be upgraded to 5.9.1 for it to compile with `esModuleInterop`.
jinwoo
force-pushed
the
esmoduleinterop
branch
from
90942cd
to
84dc19f
Compare
|
Closing this. New PR in #125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is both for the generated
package.jsonandgtsitself.TypeScript 2.7.1 added
--esModuleInteropfor better ES modulesupport. And for that, we need to turn on
allowSyntheticDefaultImportstoo.
Also
tslintmust be upgraded to 5.9.1 for it to compile withesModuleInterop.