Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @Beta from the immutable collector methods #3251

Closed
zshamrock opened this issue Aug 26, 2018 · 2 comments · Fixed by #3393
Closed

Remove @Beta from the immutable collector methods #3251

zshamrock opened this issue Aug 26, 2018 · 2 comments · Fixed by #3393
Labels
package=collect status=fixed type=debeta Request to remove something from @Beta

Comments

@zshamrock
Copy link

Like ImmutableList.toImmutableList(), ImmutableMap.toImmutableMap(), etc.

As per https://github.com/google/guava/wiki/PhilosophyExplained, specifically

On the other hand, if you want something taken out of @Beta, file an issue. We generally promote features out of @Beta only when it's specifically requested, so if you don't ask, it won't happen.

According to the source these were introduced on version 21.0 and still marked as @Beta. As the latest IntelliJ IDEA now displays warnings on any beta/unstable API usage, wondering whether you have plans to remove or reason to keep @Beta flag on these API.

@yuyumao
Copy link

yuyumao commented Oct 1, 2018

I've opened a PR to remove them. #3280

@kluever kluever added type=debeta Request to remove something from @Beta and removed type=debeta Request to remove something from @Beta labels Oct 17, 2018
@alimbada
Copy link

Hi, any chance @Beta can be removed from MoreCollectors methods as part of this issue too? If not, I'll create a separate issue.

@ronshapiro ronshapiro mentioned this issue Feb 14, 2019
ronshapiro pushed a commit that referenced this issue Feb 14, 2019
collect
- most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity))
- Maps: asConverter, immutableEnumMap
- MultimapBuilder
- Streams: stream(Iterable), concat

io
- ByteStreams: copy, toByteArray
- CharStreams: copy, toString
- Files: as(Char|Byte)(Source|Sink)

util.concurrent
- Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture
- ListeningScheduledExecutorService
- Uninterruptibles

other
- HtmlEscapers
- Splitter.splitToList
- Ticker

Fixes #3287
Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway)
Addresses the main concerns of #3285 but doesn't cover the broader request
Fixes #3340
Partially addresses #3239

RELNOTES=Removed `@Beta` from a number of frequently used APIs.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=232681253
@ronshapiro ronshapiro mentioned this issue Feb 26, 2019
ronshapiro pushed a commit that referenced this issue Feb 26, 2019
collect
- most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity))
- Maps: asConverter, immutableEnumMap
- MultimapBuilder
- Streams: stream(Iterable), concat

io
- ByteStreams: copy, toByteArray
- CharStreams: copy, toString
- Files: as(Char|Byte)(Source|Sink)

util.concurrent
- Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture
- ListeningScheduledExecutorService
- Uninterruptibles

other
- HtmlEscapers
- Splitter.splitToList
- Ticker

Fixes #3287
Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway)
Addresses the main concerns of #3285 but doesn't cover the broader request
Fixes #3340
Partially addresses #3239

RELNOTES=Removed `@Beta` from a number of frequently used APIs.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=232681253
ronshapiro pushed a commit that referenced this issue Feb 26, 2019
collect
- most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity))
- Maps: asConverter, immutableEnumMap
- MultimapBuilder
- Streams: stream(Iterable), concat

io
- ByteStreams: copy, toByteArray
- CharStreams: copy, toString
- Files: as(Char|Byte)(Source|Sink)

util.concurrent
- Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture
- ListeningScheduledExecutorService
- Uninterruptibles

other
- HtmlEscapers
- Splitter.splitToList
- Ticker

Fixes #3287
Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway)
Addresses the main concerns of #3285 but doesn't cover the broader request
Fixes #3340
Partially addresses #3239

RELNOTES=Removed `@Beta` from a number of frequently used APIs.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=232681253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package=collect status=fixed type=debeta Request to remove something from @Beta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants