Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speculative fix for issue 2365 #2437

Closed
wants to merge 1 commit into from

Conversation

mardibiase
Copy link
Contributor

Fix for #2365

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mardibiase
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@cpovirk
Copy link
Member

cpovirk commented Mar 29, 2016

Thanks. I'm asking around to find out whether NumberFormat is going to pull in undesired internationalization data (currency formats, mainly). I'll report back here.

cpovirk added a commit that referenced this pull request Mar 30, 2016
From: mardibiase <mardibiase@gmail.com>

From #2437
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=118503538
@cpovirk
Copy link
Member

cpovirk commented Mar 30, 2016

The feedback I got:

  • NumberFormat may pull in code that apps don't want.
  • NumberFormat might not be supported by j2cl.

But I also heard an alternative approach that uses JsInterop. I'm trying that now.

@cpovirk cpovirk closed this in c995616 Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants