Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added posibility to limit errors logger to prevent OOM #1122

Closed
wants to merge 1 commit into from
Closed

Added posibility to limit errors logger to prevent OOM #1122

wants to merge 1 commit into from

Conversation

IgeNiaI
Copy link

@IgeNiaI IgeNiaI commented Aug 1, 2017

In our project we encountered an issue where we got a lot of errors during guice injection. There were so much errors that the injector run into OutOfMemoryError when formatting error messages in Errors.format(String, Collection<>) method.
The behavior is pretty much the same as here: #850

I have added the possibility to set limit for errors being logged.
In the code it can be used by just calling the Errors.setMaxErrorsLogged(int) method.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@IgeNiaI
Copy link
Author

IgeNiaI commented Aug 1, 2017

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 1, 2017
@sameb
Copy link
Member

sameb commented Apr 20, 2023

Thank you for this PR. In the time since this PR was submitted, Guice has changed to group together similar error messages, which I think will reduce the chance of an OOM from many errors. If you're still experiencing OOMs after all this time, please re-open a new PR and we can take a fresh look.

@sameb sameb closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants