Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Lookup.class as the base when retrieving trusted lookup… #1673

Closed
wants to merge 1 commit into from
Closed

Use Lookup.class as the base when retrieving trusted lookup… #1673

wants to merge 1 commit into from

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Apr 7, 2023

…because we know that's where the field is declared

This hopefully fixes #1672

@mcculls mcculls mentioned this pull request Apr 7, 2023
Closed
@sameb
Copy link
Member

sameb commented Apr 14, 2023

FYI @mcculls & @breun, I'm running this change against the google codebase to confirm nothing strange happens. It's unlikely anything will crop up. Will submit on Monday if all is well.

@copybara-service copybara-service bot mentioned this pull request Apr 17, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request Apr 17, 2023
@sameb
Use Lookup.class as the base when retrieving trusted lookup because w…
37cd8ae 
…e know that's where the field is declared.

Fixes #1673
Fixes #1672

PiperOrigin-RevId: 524355899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HiddenClassDefiner incorrectly assumes Unsafe.staticFieldBase(Field) returns a real Object
2 participants
@mcculls @sameb