unsupported mode value: 'mode=755' #112
Comments
|
You're right, our regex is too restrictive. Yes, please send a PR with the fix. |
|
Just to clarify, gVisor doesn't accept git pull requests. We use Gerrit instead, please take a look at the instructions here. |
tonistiigi
pushed a commit
to tonistiigi/gvisor
that referenced
this issue
Jan 29, 2019
https://github.com/containerd/containerd/blob/master/oci/spec.go#L206, the mode=755 didn't match the pattern modeRegexp = regexp.MustCompile("0[0-7][0-7][0-7]"). Closes google#112 Signed-off-by: Juan <xionghuan.cn@gmail.com> Change-Id: I469e0a68160a1278e34c9e1dbe4b7784c6f97e5a PiperOrigin-RevId: 219672525 Upstream-commit: b23cd33
tonistiigi
pushed a commit
to tonistiigi/gvisor
that referenced
this issue
Jan 30, 2019
https://github.com/containerd/containerd/blob/master/oci/spec.go#L206, the mode=755 didn't match the pattern modeRegexp = regexp.MustCompile("0[0-7][0-7][0-7]"). Closes google#112 Signed-off-by: Juan <xionghuan.cn@gmail.com> Change-Id: I469e0a68160a1278e34c9e1dbe4b7784c6f97e5a PiperOrigin-RevId: 219672525 Upstream-commit: b23cd33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I generated a spec by https://github.com/containerd/containerd/blob/master/oci/spec.go#L48, and got an error
failed to create mount with source \"xxxxx/tmpfs\": unsupported mode value: 'mode=755'when starting gVisor container. I think it was caused by https://github.com/containerd/containerd/blob/master/oci/spec.go#L206, themode=755didn't match the patternmodeRegexp = regexp.MustCompile("0[0-7][0-7][0-7]").I was wondering if we could set the pattern to
"^[0]?[0-7][0-7][0-7]$"to adapt containerd spec? May I create a pull request to adapt to containerd?The text was updated successfully, but these errors were encountered: