Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres needs sync_file_range #88

Closed
woody01 opened this issue Jul 9, 2018 · 2 comments
Closed

postgres needs sync_file_range #88

woody01 opened this issue Jul 9, 2018 · 2 comments

Comments

@woody01
Copy link

woody01 commented Jul 9, 2018

Hello. I'm trying banchmark docker postgres with gvisor by using pgbench. I execute the following commands:

docker pull postgres
docker run --runtime=runsc -p 5000:5432 postgres

then start benchmark:

pgbench -i -p 5000 -U postgres -h localhost -d postgres # (invokes initialization mode)
pgbench -p 5000 -U postgres -h localhost -d postgres # (default test, 1 client, 10 transactions)

this test completes successfully, but if I increase the number of transactions and clients:

pgbench -c 2 -t 500 -p 5000 -U postgres -h localhost -d postgres  # (2 clients and 500 transactions)

test hangs (just stop), apparently waiting for a response from the database.
postgres spam message: WARNING: could not flush dirty data: Function not implemented
Attach logs and docker info
runsc.log.20180709-154037.490428.create.log
runsc.log.20180709-154037.494581.gofer.log
runsc.log.20180709-154037.507678.state.log
runsc.log.20180709-154037.512384.start.log
runsc.log.20180709-154037.652205.state.log
docker_info.txt

$ uname -a
Linux test_host 4.15.0-24-generic #26~16.04.1-Ubuntu SMP Fri Jun 15 14:35:08 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

postgres docker without using gvisor easy completes this test. Any idea what might be wrong?
Thanks in advance

@fvoznika
Copy link
Member

Thanks for the detailed report, Postgres is calling sync_file_range which is not implemented yet.

@fvoznika fvoznika changed the title benchmark gvisor postgres postgres needs sync_file_range Aug 22, 2018
shentubot pushed a commit that referenced this issue Aug 22, 2018
See #88

PiperOrigin-RevId: 209780532
Change-Id: Iff8004474020511503a0a5cd2cdba2b512c327ef
@fvoznika
Copy link
Member

Resolved by 2ef122d

tonistiigi pushed a commit to tonistiigi/gvisor that referenced this issue Jan 30, 2019
See google#88

PiperOrigin-RevId: 209780532
Change-Id: Iff8004474020511503a0a5cd2cdba2b512c327ef
Upstream-commit: 3c5ec25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants