Allows driverABI to be saveable
#9650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows containers started with `-nvproxy` to be checkpointed, essentially ignoring the state of the `driverABI`. The downside of this path is "[...] this would imply that the container must be restored on a host with the same nvidia driver version." Closes: google#9649 (comment) cc @ayushr2
ayushr2
reviewed
Nov 7, 2023
Comment on lines
+125
to
+128
| frontendIoctl map[uint32]frontendIoctlHandler `state:"nosave"` | ||
| uvmIoctl map[uint32]uvmIoctlHandler `state:"nosave"` | ||
| controlCmd map[uint32]controlCmdHandler `state:"nosave"` | ||
| allocationClass map[uint32]allocationClassHandler `state:"nosave"` |
There was a problem hiding this comment.
Hmm drop the nosave annotations? Otherwise these maps will be nil. Are these required? Function pointers should be savable.
There was a problem hiding this comment.
Checkpointing panics if I don't add nosave to the functions (added error logs in attachment). All errors are similar:
unknown object (nvproxy.frontendIoctlHandler)(0xc28380): ...
unknown object (nvproxy.controlCmdHandler)(0xc2a420): ...
unknown object (nvproxy.allocationClassHandler)(0xc36780): ...
unknown object (nvproxy.uvmIoctlHandler)(0xc3cdc0): ...
There was a problem hiding this comment.
Hmm such a restore would be useless (as the ABI is essentially empty).
|
Could you see if #9653 fixes your issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches the
driverABIstruct, allowing containers started with-nvproxyto be checkpointed. The downside of this patch isCloses: #9649
cc @ayushr2