Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

Add recreateControls flag to the OnDataChanged list/tree event. #154

Merged
merged 1 commit into from
Aug 25, 2015

Conversation

ben-clayton
Copy link
Contributor

This allows the adapter to indicate that there was UI changes for existing elements, while keeping selection and scroll position.

This allows the adapter to indicate that there was UI changes for existing
elements, while keeping selection and scroll position.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ben-clayton
Copy link
Contributor Author

@sunwangme - I'd definitely agree if we had three or more states for this parameter, or more parameters to the function, but I decided a bool here is fine given that Sublime and Atom can both offer parameter info. I also considered adding a 3rd function DataChanged / DataReplaced, but that just seemed even more confusing.

ben-clayton added a commit that referenced this pull request Aug 25, 2015
Add recreateControls flag to the OnDataChanged list/tree event.
@ben-clayton ben-clayton merged commit 92ee22e into master Aug 25, 2015
@ben-clayton ben-clayton deleted the recreate_ctrls branch August 25, 2015 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants