Fix the Haskell indexer on plugins with ghc-8.6. #94
Conversation
haskell-indexer-backend-ghc/src/Language/Haskell/Indexer/Backend/GhcApiSupport.hs
Outdated
Show resolved
Hide resolved
|
Robin, this code works only for GHC >8.6. We have CI setups for many old GHC versions. Do we want to support those? Do I have to add version conditionals around this code? |
|
Added |
|
This fixes #93. |
|
This PR now sits on the top of #95. |
jinwoo
force-pushed
the
plugins
branch
2 times, most recently
from
8f749ca
to
8ffe6a2
Compare
Upstreaming a local change. The GHC API changed and now requires explicitly loading plugins for each module.
|
@jinwoo I'm not very concerned about supporting older GHCs, given the tool is not widespread. If it ever becomes a burden, feel free to remove non-recent configurations from CI and maybe the related conditionals in code. Thanks for making it green! Eventually we can develop a more specific strategy about version support. |
|
Thanks, @robinp . Now that the builds are fixed, there doesn't seem to be a big burden for maintaining the old versions for now. But longer term, we'll have to add newer GHCs (8.8.*) and remove older ones. Merging now. |
Also fix the wrong __GLASGOW_HASKELL__ conditions from my google#94. Its value for GHC v8.6.1 is not 861 but 806 (ignoring the patch version).
Generate v-names in one line, without newlines. Upstreaming another local change. This also removes excessive whitespaces in v-names. Also delete unused imports and functions. Also fix the wrong __GLASGOW_HASKELL__ conditions from my #94. Its value for GHC v8.6.1 is not 861 but 806 (ignoring the patch version).
Upstreaming a local change.
The GHC API changed and now requires explicitly loading plugins for each module.