Update polyval API #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nhukc
commented
Oct 27, 2021
•
nhukc
commented
- Give polyval a standard hash interface
- Remove polyval specific code from hcrt2.c
ciphergoth
reviewed
Oct 27, 2021
| @@ -110,13 +137,37 @@ void polyval_generic(const u8 *in, const struct polyval_key *key, | |||
| } | |||
| } | |||
|
|
|||
| /* | |||
| * If the message is not a multiple of 16 bytes, the last block should be | |||
There was a problem hiding this comment.
If possible, I'd prefer if our implementation of polyval didn't handle odd-sized messages at all, and left all that to the caller.
There was a problem hiding this comment.
Made a separate issue regarding this. #4
ebiggers
reviewed
Oct 27, 2021
ebiggers
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.