Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ND secret tensors in insert-rotate #588

Closed
j2kun opened this issue Apr 2, 2024 · 2 comments
Closed

Handle ND secret tensors in insert-rotate #588

j2kun opened this issue Apr 2, 2024 · 2 comments
Labels
dialect: tensor_ext Issues concerning the tensor_ext dialect

Comments

@j2kun
Copy link
Collaborator

j2kun commented Apr 2, 2024

#587 identified that we may need to determine how to handle multidimensional secret inputs in insert-rotate or upstream of it.

Just brainstorming: it seems like what we would want to do is determine in advance of insert-rotate how to convert multidimensional tensors to 1D tensors. Perhaps that means we take any ND function inputs and add reshape ops at the very beginning and end, though that would have a pretty large effect on the intermediate IR, requiring one to convert any tensor index-accessing ops to the corresponding flattened version. Even so, we must have gotten most, if not all, of the hard work done when we did this for verilog codegen. We can probably reuse that.

@j2kun j2kun added the dialect: tensor_ext Issues concerning the tensor_ext dialect label Apr 2, 2024
@j2kun
Copy link
Collaborator Author

j2kun commented Jun 30, 2024

I think the SIMD packing work will handle this. Optimistically closing.

@j2kun j2kun closed this as completed Jun 30, 2024
@asraa
Copy link
Collaborator

asraa commented Jul 1, 2024

I'll update the SIMD packing to clarify the ND case as a TODO - we talked a little about collapsing tensors as well, and I need to recap that discussion in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialect: tensor_ext Issues concerning the tensor_ext dialect
Projects
None yet
Development

No branches or pull requests

2 participants