Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGGI Dialect and LWE ciphertexts #218

Merged
merged 1 commit into from
Nov 6, 2023
Merged

CGGI Dialect and LWE ciphertexts #218

merged 1 commit into from
Nov 6, 2023

Conversation

asraa
Copy link
Collaborator

@asraa asraa commented Oct 31, 2023 •
edited
Loading

  • Moves LWECiphertext type to the LWE dialect
  • Adds an LWEPlaintext type and encode operation to the LWE dialect
  • Adds a CGGI trivial encryption into a ring to get an LWECiphertext type (it's possible this could also go to LWE?)

This gives sufficient functionality to implement a LUT based lowering from comb dialect.

@asraa asraa force-pushed the cggi-dialect branch 2 times, most recently from 1f952fc to cc40b7c Compare November 1, 2023 15:29
@asraa asraa changed the title WIP: CGGI Dialect and LWE ciphertexts CGGI Dialect and LWE ciphertexts Nov 1, 2023
@asraa asraa marked this pull request as ready for review November 1, 2023 15:33
@asraa asraa requested a review from j2kun November 1, 2023 16:02
@asraa
Copy link
Collaborator Author

asraa commented Nov 1, 2023

This is ready for a review (sorry for the late PR! laptop was new...)

asraa
asraa commented Nov 1, 2023
View reviewed changes
tests/cggi/syntax.mlir Outdated Show resolved Hide resolved
j2kun
j2kun requested changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@j2kun j2kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits, except for the question about whether LWECiphertext will be both RLWE and LWE. I think we should have RLWE as its own type.

include/Dialect/CGGI/IR/CGGIOps.td Outdated Show resolved Hide resolved
include/Dialect/LWE/IR/LWETypes.td Outdated Show resolved Hide resolved
tests/cggi/syntax.mlir Outdated Show resolved Hide resolved
include/Dialect/LWE/IR/LWETypes.td Outdated Show resolved Hide resolved
@asraa asraa force-pushed the cggi-dialect branch 2 times, most recently from 6b2e583 to 347861f Compare November 2, 2023 15:39
@asraa asraa added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Nov 2, 2023
copybara-service bot pushed a commit that referenced this pull request Nov 6, 2023
@asraa @copybara-github
Fix header orderings
704d6d9 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#218 from asraa:cggi-dialect c23d96f
PiperOrigin-RevId: 579907461
@copybara-service copybara-service bot mentioned this pull request Nov 6, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request Nov 6, 2023
@asraa @copybara-github
Fix header orderings
955613e 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#218 from asraa:cggi-dialect c23d96f
PiperOrigin-RevId: 579907461
@asraa asraa merged commit 560ab78 into google:main Nov 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j2kun j2kun j2kun approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asraa @j2kun