fix dimension check in bgv.mul verifier #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Just needs a rebase I believe. |
j2kun
approved these changes
Jun 10, 2024
AlexanderViand-Intel
force-pushed
the
bgv_mul_verifier_dimension_fix
branch
from
68b5864
to
b2ae4ee
Compare
Done :) |
j2kun
approved these changes
Jun 11, 2024
j2kun
added
the
pull_ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifier logic for
bgv.muloutput degree was incorrect (and did not match type inference logic, which was correct).With this fix, you should now be able to express multiplications of already multiplied values (without a relinerization in between) which might be helpful for the layz relin optimization (#599)