Refactoring per issue #449 #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR intended to have code changes for verilog emitter instead of cmake changes? |
Yes; the PR is only added for completeness and I'm hoping the PR raised for 3312deb is merged before this one |
…emitter; - the Verilog code is refactored with TfheRustBool; however the TfheRust code is different in being a sum of products which is handled here. - Fixes google#449
ai-mannamalai
force-pushed
the
ma-Aug23
branch
from
fe5b2a1
to
23ea2ef
Compare
I dropped the CMakeLists change |
|
reminder |
j2kun
approved these changes
Aug 29, 2024
j2kun
added
the
pull_ready
asraa
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring per issue #449
#449: cleanup: share components of verilog emitter and tfhe-rs emitter;
- the Verilog code is refactored with TfheRustBool; however the TfheRust code is different in being a sum of products
which is handled here.
Fixes #449