Adds long and double-click support to Button and Card #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Credit to @yschimke for much of the work)
yschimke
reviewed
Feb 2, 2024
...t/snapshots/images/com.google.android.horologist.compose.material_ButtonA11yTest_default.png
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Feb 2, 2024
...ylistDownloadScreenA11yScreenshotTest_playlistDownloadScreenPreviewLoadedFullyDownloaded.png
Outdated
Show resolved
Hide resolved
|
Had a stab at improving the Compose semantics handling |
yschimke
reviewed
Feb 6, 2024
.../snapshots/images/com.google.android.horologist.compose.material_ButtonA11yTest_disabled.png
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Feb 6, 2024
compose-material/src/main/java/com/google/android/horologist/compose/material/Card.kt
Show resolved
Hide resolved
yschimke
reviewed
Feb 9, 2024
| onDoubleClick = onDoubleClick, | ||
| role = role, | ||
| ) | ||
| .padding(contentPadding), |
yschimke
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Credit to @yschimke for much of the work)
WHAT
Adds
onLongClickandonDoubleClicksupport toCardandButtonWHY
These are not provided by default in the Wear Compose implementation, but are useful in a number of scenarios.
HOW
Custom
CardandButtonimplementations, usingBoxto handle the long and double-click interactions.Checklist 📋