Send 'session start' and 'io start' push pings #1340
Conversation
|
@ebidel I realised phase3 is due May 26 which is actually the latest this PR should be deployed on prod. so, probably no need for merge-into-phase2. |
|
Yep. Strictly phase 3. On Sun, May 10, 2015, 3:33 PM alex notifications@github.com wrote:
|
| @@ -8,3 +8,6 @@ cron: | |||
| - description: sync schedule data | |||
| url: $PREFIX$/sync/gcs | |||
| schedule: every 30 minutes | |||
| - description: sessions start notifications | |||
| url: $PREFIX$/task/clock | |||
| schedule: every 1 min | |||
There was a problem hiding this comment.
is every 1min excessive? Should we put the cron on 5min? GCM might take longer than that though to propagate.
There was a problem hiding this comment.
Ah, I see below you need this to run more frequently.
There was a problem hiding this comment.
yeah, I wanted to give GCM as much time as possible to deliver msgs.
|
PTAL |
|
This looks good to me. I'm working on the client-side changes now, but I'm not anticipating that you'd have to change anything you're doing server-side. |
Send 'session start' and 'io start' push pings
Can't verify with dev/stage server until @jeffposnick implements #1248 but confirmed by tests.
Closes #1293.