This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Implements cache-then-network requests #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // a HTTP 204 with an empty body if the request wasn't found in the cache. | ||
| if (this.status < 400 && freshContentPending && this.responseText) { | ||
| cachedResponse = this.responseText; | ||
| cachedContentCallback(JSON.parse(cachedResponse)); |
There was a problem hiding this comment.
You would be able to get away with xhr.responseType = 'json' since all browsers that support SW, support that responseType :)
There was a problem hiding this comment.
I'd rather keep it consistent with the XHR for the fresh request, and since IE10 doesn't support responseType, I can't use it there.
|
Reviewed |
jeffposnick
added a commit
that referenced
this pull request
Jan 14, 2015
Implements cache-then-network requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ebidel @wibblymat
Closes #180.
IOWA.Request.cacheThenNetwork()isn't used anywhere yet, so the next step will be to try it out for the social feeds (starting with a dummy file under/temporary_api/).Jake gave the implementation a 👍, for what it's worth.