Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a mappings file renames a method with reserved words as arguments, these are not suffixed with underscores #389

Closed
nbransby opened this issue Jun 26, 2014 · 4 comments

Comments

@nbransby
Copy link

No description provided.

@larrytin
Copy link

e.g. JsonObject set(String key, boolean bool);
bool is an objective-c keyword

@nbransby
Copy link
Author

@tomball did you get a chance to look at these?

@tomball
Copy link
Collaborator

tomball commented Jul 11, 2014

Not yet. Bug cleanup continues...

On Fri Jul 11 2014 at 5:03:00 AM, nbransby notifications@github.com wrote:

@tomball https://github.com/tomball did you get a chance to look at
these?


Reply to this email directly or view it on GitHub
#389 (comment).

@tomball
Copy link
Collaborator

tomball commented Sep 14, 2022

This should be fixed, now that mapping files take the JVM binary signature for a method (doc: https://developers.google.com/j2objc/guides/changing-method-names?hl=en#mapping_file). For example, "JsonObject set(String key, boolean bool)" would be defined as "set(Ljava/lang/String;Z)L/JsonObject;"

@tomball tomball closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants