Now calling the xcodebuild -create-xcframework command with the -headers option

[adil-hussain-84]

Updated the make/framework.mk and scripts/gen_xcframework.sh files so that the xcodebuild -create-xcframework command is called with the -headers option. Fixes #2180.

[mungler]

Nice work @adil-hussain-84 - this does indeed produce valid XCFramework artefacts which seem to comply with Apple's specification. The /usr/bin/codesign tool is still happy that its a valid framework, and thus Xcode 15 will compile projects using the framework without issue.

👍 for merge

[mungler]

@tomball FYI I have approved this PR but still see the message "At least 1 approving review is required by reviewers with write access." - does someone else need to approve, or will this be picked up automatically?

[tomball]

Thanks for the clear comments describing what's done in this PR. No need to guess!

[tomball]

Yes, someone from Github's Google org needs to approve, which I just did. Instead of merging this PR, the next process step will cause the PR to be staged internally as a change request, requiring another engineer to approve, and then it gets automatically merged (Google has to be super-careful about how changes are integrated into its source base). This should happen automatically, but I'm always a little amazed when it works. :-)

…

On Tue, Sep 19, 2023 at 2:12 PM Rory Sinclair ***@***.***> wrote: @tomball <https://github.com/tomball> FYI I have approved this PR but still see the message "At least 1 approving review is required by reviewers with write access." - does someone else need to approve, or will this be picked up automatically? — Reply to this email directly, view it on GitHub <#2181 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAW2JL5ACDY666CURW2TJQ3X3IDEDANCNFSM6AAAAAA455WHSQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mungler]

Haha sounds good @tomball 👌

[tomball]

Copybara is our repo-syncing service. We're good here, and thanks to you both for your contribution and help!

[mungler]

I did very little other than try out @adil-hussain-84 ’s changes, but you’re most welcome 👌

[adil-hussain-84]

@tomball @mungler: Thank you both for reviewing, approving and merging 👍👍 Sadly, it's looking like this not the last pull request from me related to XCFrameworks 😭 A number of the XCFrameworks that are being built have the same module name (i.e. JRE) in their module.modulemap file. The implication of this is that two modules with the same cannot be linked into the same target. I see that there is an open Issue and Pull Request related to this already. I'll post in there and draw attention to it.