Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Dart 3 Record types #1314

Merged
merged 1 commit into from
May 16, 2023
Merged

Support Dart 3 Record types #1314

merged 1 commit into from
May 16, 2023

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented May 11, 2023 •
edited
Loading

Closes #1222

@kevmoo kevmoo force-pushed the 1222_record_support branch 2 times, most recently from 5738073 to 2444fb1 Compare May 16, 2023 00:26
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:json_serializable 6.7.0 ready to publish json_serializable-v6.7.0
package:json_annotation 4.8.1 already published at pub.dev
package:checked_yaml 2.0.3 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@kevmoo kevmoo changed the title Dart 3 wip Support Dart 3 Record types May 16, 2023
@kevmoo
Copy link
Collaborator Author

kevmoo commented May 16, 2023

The implementation is less than 200 lines. Most of this is auto-generated test code.

@kevmoo kevmoo marked this pull request as ready for review May 16, 2023 03:33
@kevmoo kevmoo mentioned this pull request May 16, 2023
Closed
jakemac53
jakemac53 approved these changes May 16, 2023
View reviewed changes
json_serializable/lib/src/type_helpers/record_helper.dart
@@ -0,0 +1,124 @@
import 'package:analyzer/dart/element/type.dart';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: copyright

json_serializable/lib/src/type_helpers/record_helper.dart Show resolved Hide resolved
@kevmoo kevmoo merged commit be8e9a3 into master May 16, 2023
@kevmoo kevmoo deleted the 1222_record_support branch May 16, 2023 18:23
@Dampfwalze
Copy link

Are there examples or other documentation on how to serialize and deserialize records?

@kevmoo
Copy link
Collaborator Author

kevmoo commented Jul 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Records
4 participants
@kevmoo @Dampfwalze @jakemac53 @natebosch