Custom types #104
Open
Custom types #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…top-level to embedded
…edded structs; should just continue on success
…der of processing of visitModelNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is on top of PR #100. That one should get reviewed first for clarity.
Since I had an opportunity, and was already deep into some jsonapi work, I implemented support for struct fields of custom types.
In order to get support for custom types, it must implement the json.Marshaler/json.Unmarshaler interfaces. I included 2 examples custom types that I think could be useful to a wide audience (also might want to use it later to refactor the time.Time value support). This feature should also technically supports these issues: #49 and #74. Those "structs" in those examples are (custom) types declarations.