Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arm64 (aka aarch64) platform #6

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

SJLC
Copy link

@SJLC SJLC commented Sep 10, 2017

Started from amd64 table, then updated table (removed unsupported,
updated numbers) based on syscall list extracted from aarch64 kernel:
https://github.com/hrw/syscalls-table

There were a couple differences in naming conventions from that used here:
uname -> newuname
fstat -> newfstat

That syscall list includes a few more syscalls (pkey_alloc, pkey_free,
pkey_mprotect) that could be added later for all 3 platforms...

Started from amd64 table, then updated table (removed unsupported,
updated numbers) based on syscall list extracted from aarch64 kernel:
https://github.com/hrw/syscalls-table

There were a couple differences in naming conventions from that used here:
uname -> newuname
fstat -> newfstat

That syscall list includes a few more syscalls (pkey_alloc, pkey_free,
pkey_mprotect) that could be added later for all 3 platforms...
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@SJLC
Copy link
Author

SJLC commented Sep 10, 2017

I have to submit my phone number to google in order to contribute to kafel?

@robertswiecki
Copy link
Collaborator

IANAL, though would it be possible to provide any phone number that can be potentially used to contact you (to satisfy this CLA requirement)? Otherwise, I'll have to figure out whether this can be dropped from 'required fields' possibly for all projects, which might take time and with not of a big chance to succeed IMO.

PS: I really appreciate your PR

@SJLC
Copy link
Author

SJLC commented Sep 15, 2017

It would be good at least ask if it can be dropped it from required, probably I'm not the only one who wants to be contacted by email rather than phone...
but I did fill it out rather than making things difficult for you. Thanks for maintaining this project.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@SJLC
Copy link
Author

SJLC commented Sep 15, 2017

my co-author filled out the CLA as well now

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@rlc2
Copy link
Contributor

rlc2 commented Sep 15, 2017

I'm the other commit author and it's ok to use my contributions.

@robertswiecki
Copy link
Collaborator

Thanks! Seems all contributors confirmed. Awesome.

@robertswiecki robertswiecki merged commit 2ae8e11 into google:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants