Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better to disable copying of SequentialFile and RandomAccessFile #27

Closed
cmumford opened this issue Sep 9, 2014 · 3 comments
Closed

Better to disable copying of SequentialFile and RandomAccessFile #27

cmumford opened this issue Sep 9, 2014 · 3 comments
Assignees
@cmumford

Comments

@cmumford
Copy link
Contributor

cmumford commented Sep 9, 2014

Original issue 21 created by giantchen on 2011-07-17T15:11:01.000Z:

Not a bug, but a coding style improvement. To prevent anyone from passing SequentialFile or RandomAccessFile by value to a function incidentally.

What version of the product are you using? On what operating system?

Revision 37. on Ubuntu 10.04 x86-64 with g++ 4.4.3
@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #1 originally posted by tfarina@chromium.org on 2011-07-17T17:35:02.000Z:

<empty>

@cmumford cmumford self-assigned this Sep 9, 2014
@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #2 originally posted by sanjay@google.com on 2012-05-30T17:23:07.000Z:

<empty>

@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #3 originally posted by sanjay@google.com on 2012-10-08T21:23:22.000Z:

<empty>

@cmumford cmumford closed this as completed Sep 9, 2014
@magicSwordsMan magicSwordsMan mentioned this issue Jul 19, 2019
Open
@orrorcol orrorcol mentioned this issue Dec 15, 2019
Closed
maochongxin pushed a commit to maochongxin/leveldb that referenced this issue Jul 21, 2022
@dominichamon
Merge pull request google#27 from pleroy/TwoBugs
7c428e9 
Two bug fixes in KeepRunning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmumford cmumford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmumford