-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build for OS X. #8
Comments
Comment #1 originally posted by tfarina@chromium.org on 2011-05-22T18:07:01.000Z: <empty> |
Comment #2 originally posted by tim%creationix.com@gtempaccount.com on 2011-05-23T21:23:29.000Z: Would this patch not be better? https://github.com/davisp/leveldb/commit/50e280c9b1cfde0e255d124f38e1aa436d36ba52 |
Comment #3 originally posted by paul.joseph.davis on 2011-05-23T21:39:18.000Z: That's the same patch. I attached it as a diff to prevent link rot. |
Comment #4 originally posted by paul.joseph.davis on 2011-05-23T23:06:02.000Z: Also, link rot rears its ugly head. A more permanent link: |
Comment #5 originally posted by s@little--eyes.com on 2011-05-25T20:01:07.000Z: Thanks for sharing this. It seems like I successfully applied the patch using from the leveldb root: But I'm getting this error when I call 'make'.
This is with gcc version 4.2.1 (Apple Inc. build 5664) |
Comment #6 originally posted by paul.joseph.davis on 2011-05-25T20:25:25.000Z: There are a couple lines in the Makefile that you need to change for OS X. The CFLAGS variable needs to change as well as a change to the list of sources. There's comments in the Makefile that are specific to what needs to happen. |
Comment #7 originally posted by stefeo on 2011-05-25T20:47:30.000Z: Thank you, that worked (I also had to apply your log_test patch [1]). What is the step following 'make' to actually build the library? |
Comment #8 originally posted by tfarina@chromium.org on 2011-05-25T20:53:04.000Z: There is no library code yet on the Makefile. :( Patches welcome. |
Comment #9 originally posted by stefeo on 2011-05-25T23:54:01.000Z: Adding this to the Makefile:
and calling 'make library' seemed to do the trick. As a side note, adding -fvisibility=hidden to the CFLAGS seemed to get rid of 33 visibility warnings I was getting. |
Comment #10 originally posted by ashoemaker on 2011-06-06T20:55:23.000Z: It seems this is fixed as of r29 - make runs without warnings or errors on XCode 3 and 4. |
Comment #11 originally posted by dgrogan@chromium.org on 2011-06-16T09:44:11.000Z: <empty> |
Cmake edit with 'make install' target
Original issue 2 created by paul.joseph.davis on 2011-05-08T22:17:55.000Z:
LevelDB fails to build on OS X with standard GCC from XCode and so on and such forth.
This patch mixes up the Posix and Chromium port implementations as well as pulls in a couple Chromium headers so that building on OS X is possible without requiring that users build GCC 4.5.
Patch commit is at [1] and attached as a diff.
[1] https://github.com/davisp/leveldb/commit/50e280c9b1cfde0e255d124f38e1aa436d36ba52
The text was updated successfully, but these errors were encountered: