Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpoison results from LLVMFuzzerMutate. #213

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

Allen-Webb
Copy link
Contributor

LLVMFuzzerMutate was returning data marked as uninitialized, but it should be treated at initialized when running with the memory sanitzer.

LLVMFuzzerMutate was returning data marked as uninitialized, but it
should be treated at initialized when running with the memory sanitzer.
Copy link
Collaborator

@vitalybuka vitalybuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you compile the mutator with msan?
is protobuf msan instrumented?

@Allen-Webb
Copy link
Contributor Author

I went back and double checked and libprotobuf-mutator, libprotobuf-mutator-libfuzzer, libprotobuf, and the fuzzing target are all built with the memory sanitizer flags.

@vitalybuka
Copy link
Collaborator

Is this still relevant?

@Allen-Webb
Copy link
Contributor Author

@vitalybuka vitalybuka merged commit e49cb00 into google:master Jan 17, 2024
vitalybuka added a commit to vitalybuka/libprotobuf-mutator that referenced this pull request Jan 17, 2024
vitalybuka added a commit that referenced this pull request Jan 17, 2024
onionpsy pushed a commit to CodeIntelligenceTesting/libprotobuf-mutator that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants