fix rerun rule for build.rs #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had unneeded double-quotes for rerun-if-changed due to Debug formatting of Path, which caused rebuilding every time
crosvm-bot
pushed a commit
to google/crosvm
that referenced
this pull request
Nov 6, 2023
With a fix in libtracemd-rs v0.2.1 [1], we no longer need to rebuild libtracecmd-rs every time. [1]: google/libtracecmd-rs#6 BUG=none TEST=cargo build Change-Id: Ica1342c9b23ed778fff2c0677717e3953b42dbd9 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5000825 Auto-Submit: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by: Ryuichiro Chiba <chibar@chromium.org> Reviewed-by: Morg <morg@google.com> Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had unneeded double-quotes for rerun-if-changed due to Debug formatting of Path, which caused rebuilding every time