Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add version to the shared library #172

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

spvkgn
Copy link
Contributor

@spvkgn spvkgn commented Jun 14, 2024

If planned to add to major Linux distros, the shared library should be versioned, i.e. as described in Debian policy.

$ tree
.
├── include
│   └── ultrahdr_api.h
└── lib
    ├── libuhdr.so -> libuhdr.so.1
    ├── libuhdr.so.1 -> libuhdr.so.1.0
    ├── libuhdr.so.1.0
    └── pkgconfig
        └── libuhdr.pc

Copy link

google-cla bot commented Jun 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@DichenZhang1 DichenZhang1 merged commit 4ef6913 into google:main Aug 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants