This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Move linkopts to llvm:Support #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 23, 2021
We moved these to the library that actually needs them (llvm:Support) in #189 PiperOrigin-RevId: 370101023
lelandjansen
pushed a commit
to lelandjansen/llvm-bazel
that referenced
this pull request
May 2, 2021
`-lm` is needed by Support itself. Adding this on every possible leaf binary seems a bit silly. There will be some weirdness by nature of this being a transitive thing (line `includes`) that means we might have some things happen to work because they dep on Support even though there are other libraries that really should have those options as well and don't have them, but I'm not sure how to avoid that. Luckily the linker error gives you the name of the object file, so I think adding the option on the appropriate library if/when that comes up shouldn't be too bad. Fixes google#188
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-lmis needed by Support itself. Adding this on every possible leafbinary seems a bit silly. There will be some weirdness by nature of
this being a transitive thing (line
includes) that means we mighthave some things happen to work because they dep on Support even though
there are other libraries that really should have those options as well
and don't have them, but I'm not sure how to avoid that. Luckily the
linker error gives you the name of the object file, so I think adding
the option on the appropriate library if/when that comes up shouldn't
be too bad.
Fixes #188