Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clang-format and formatted all the .cc/.h files in the repository #17

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

Siddhant-K-code
Copy link
Contributor

fixes #14

Changes:

  • Added .clang-format in the root
  • Formatted Using Command on Ubuntu:
find . -regex '.*\.\(cpp\|h\|cc\)'  -exec clang-format -style=file -i {} \; 

Using Command ```sh
find . -regex '.*\.\(cpp\|h\|cc\)'
-exec clang-format -style=file -i {} \;
```
on Ubuntu

Signed-off-by: Siddhant Khare <siddhantkhare2694@gmail.com>
@Siddhant-K-code
Copy link
Contributor Author

@aluebs Please Review!

Copy link
Contributor

@aluebs aluebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding clang-format.

@aluebs aluebs merged commit de68783 into google:main Apr 14, 2021
@EwoutH
Copy link
Contributor

EwoutH commented Apr 20, 2021

Would it be useful to add a job to the CI that runs a linter following the .clang-format spec? Either as a check or pre-commit?

@Siddhant-K-code
Copy link
Contributor Author

No, currently it is for formatting only and then you have to commit it, we can add a CI for the same so that it formats all the files with this .clang-format while merging the new commits/PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Clang Formatter To The Repository
3 participants