-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Ensure MARL_BUILD_TESTS works #7
Conversation
The conditional for building tests was written as simply "BUILD_TESTS". This commit changes it to use "MARL_BUILD_TESTS". With this commit, my POWER9 in Big Endian mode can build, run, and pass the Marl test suite.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Who would I poke about an issue with googlebot? There's a stray close-paren in the directive to respond once the CLA has been signed. |
Thank you @awilfox. I must have broken this earlier today. |
Thanks for also spotting and reporting this! I'll do some digging and see if I can find the right people. |
I reported this to the relevant team, and they have made a fix. It should take affect sometime next week. Thank you! |
The conditional for building tests was written as simply "BUILD_TESTS".
This commit changes it to use "MARL_BUILD_TESTS".
With this commit, my POWER9 in Big Endian mode can build, run, and pass
the Marl test suite.