Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Ensure MARL_BUILD_TESTS works #7

Merged
merged 1 commit into from
Sep 4, 2019
Merged

CMake: Ensure MARL_BUILD_TESTS works #7

merged 1 commit into from
Sep 4, 2019

Conversation

awilfox
Copy link
Contributor

@awilfox awilfox commented Sep 4, 2019

The conditional for building tests was written as simply "BUILD_TESTS".
This commit changes it to use "MARL_BUILD_TESTS".

With this commit, my POWER9 in Big Endian mode can build, run, and pass
the Marl test suite.

The conditional for building tests was written as simply "BUILD_TESTS".
This commit changes it to use "MARL_BUILD_TESTS".

With this commit, my POWER9 in Big Endian mode can build, run, and pass
the Marl test suite.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@awilfox
Copy link
Contributor Author

awilfox commented Sep 4, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@awilfox
Copy link
Contributor Author

awilfox commented Sep 4, 2019

Who would I poke about an issue with googlebot? There's a stray close-paren in the directive to respond once the CLA has been signed.

@ben-clayton
Copy link
Contributor

Thank you @awilfox. I must have broken this earlier today.
I'm currently trying to get our presubmits running which should catch this sort of thing in the future.
Very much appreciate the fix!

@ben-clayton
Copy link
Contributor

Who would I poke about an issue with googlebot? There's a stray close-paren in the directive to respond once the CLA has been signed.

Thanks for also spotting and reporting this! I'll do some digging and see if I can find the right people.

@ben-clayton ben-clayton merged commit 2e9f0ab into google:master Sep 4, 2019
@ben-clayton
Copy link
Contributor

Who would I poke about an issue with googlebot? There's a stray close-paren in the directive to respond once the CLA has been signed.

I reported this to the relevant team, and they have made a fix. It should take affect sometime next week.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants