HAR PostData text is wrong type

[jba]

har.PostData.Text, the body of a POST, has type string. This is a mistake. It should be []byte.

The HAR spec does say that text is a string, but it means a JSON string, not a Go string. POST data can contain arbitrary bytes (e.g. if the MIME type is application/octet-stream).

The reason this matters is that encoding/json.Marshal expects strings to be valid UTF-8; if they are not, it loses information by replacing invalid code points with the replacement character. So when a har.Log is marshaled to JSON, the result is wrong.

Example:

    pd := &har.PostData{Text: string([]byte{150, 151, 152})}
    bytes, err := json.Marshal(pd)
    if err != nil {
        log.Fatal(err)
    }
    fmt.Printf("%v\n", string(bytes))

Output:

{"mimeType":"","params":null,"text":"\ufffd\ufffd\ufffd"}

[jba]

I'm happy to provide a PR if you're OK with this (it is a breaking change).

[bramhaghosh]

Ah good catch - yep I'd be happy to take a PR! Please add a test to cover this behavior as well. Much appreciated! Bramha

…

On Fri, May 25, 2018, 10:52 AM Jonathan Amsterdam ***@***.***> wrote: I'm happy to provide a PR if you're OK with this (it is a breaking change). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#245 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADI-QO3kJfapyiyIqZD0pO-dRcwcDgYks5t2ETRgaJpZM4UOWwe> .