This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
file reorg #57
Merged
file reorg #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in simplifyFractions folder
evykassirer
force-pushed
the
ek_file_reorg
branch
from
5d971f5
to
806b44a
Compare
|
I'm gonna work on this some more today probably |
evykassirer
commented
Dec 25, 2016
|
|
||
| module.exports = { | ||
| expressionStepper: simplifyExpression.stepThrough, | ||
| // TODO: after deploying this and then the update to Athena. |
There was a problem hiding this comment.
this part is important to see
evykassirer
commented
Dec 25, 2016
| @@ -1,420 +0,0 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
PolynomialTermOperations.js is gone now! :)
evykassirer
commented
Dec 25, 2016
| return NodeStatus.noChange(node); | ||
| } | ||
|
|
||
| function multiplyPolynomialTerms(node) { // TODO: do this for add too |
There was a problem hiding this comment.
oh I can take out this TODO
evykassirer
commented
Dec 25, 2016
| return NodeStatus.noChange(node); | ||
| } | ||
| } | ||
| // TODO(ael): make nthRoot a folder and sort out these functions better |
There was a problem hiding this comment.
left this for later, cause I wasn't sure what the best way to structure it was
evykassirer
commented
Dec 25, 2016
| const reduceMultiplicationByZero = require('./reduceMultiplicationByZero'); | ||
| const reduceZeroDividedByAnything = require('./reduceZeroDividedByAnything'); | ||
| const rearrangeCoefficient = require('./rearrangeCoefficient'); | ||
| // TODO: move the rest of the functions into their own files too |
There was a problem hiding this comment.
I might make this an issue, it's not super important but would feel cleaner I think
aelnaiem
approved these changes
Dec 26, 2016
|
Let's merge this :) |
|
k one sec gonna remove a stale comment and merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
stepat all, use the first step from stepThrough for tests that teststep)... and anything else!
NOT IN THIS PR: moving removeParens, that should be it's own PR