Set POT-Creation-Date in newly generated POT files #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data is added to PO files automatically by `msgmerge`. This will in turn be used when publishing a translation: it allows us to know which sources goes into a given PO file. Part of #16.
mgeisler
force-pushed
the
pot-creation-date
branch
from
18a922b
to
0cdc55b
Compare
|
@sakex, I'm thinking we should surface this field in the template engine. That way we can write something like
in the footer of each page. |
|
Sure, this can be done by adding the variable to the book object at the gettext preprocessor step, then we'll retrieve it from a custom template |
mgeisler
added a commit
to google/comprehensive-rust
that referenced
this pull request
Sep 24, 2023
This updates each PO file to the date when it was last touched:
for po_file in po/*.po; do
POT_DATE=$(git log -1 --date=short --format=%ad $po_file)
sed -i -e 's/"POT-Creation-Date:.*"/"POT-Creation-Date: '$POT_DATE'\\n"/' $po_file
done
The dates will be updated with `msgmerge` in the future via
google/mdbook-i18n-helpers#87.
mgeisler
added a commit
to google/comprehensive-rust
that referenced
this pull request
Sep 24, 2023
This updates each PO file to the date when it was last touched:
for po_file in po/*.po; do
POT_DATE=$(git log -1 --date=short --format=%ad $po_file)
sed -i -e 's/"POT-Creation-Date:.*"/"POT-Creation-Date: '$POT_DATE'\\n"/' $po_file
done
The dates will be updated with `msgmerge` in the future via
google/mdbook-i18n-helpers#87.
Oh, interesting! Can a preprocessor modify the metadata passed onto later preprocessors and renderers? I was thinking it should become a context variable for the template engine. |
|
Yes actually, we could just pass time.now from the renderer On Sep 25, 2023 08:56, Martin Geisler ***@***.***> wrote:
Sure, this can be done by adding the variable to the book object at the gettext preprocessor step
Oh, interesting! Can a preprocessor modify the metadata passed onto later preprocessors and renderers? I was thinking it should become a context variable for the template engine.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
mgeisler
added a commit
to google/comprehensive-rust
that referenced
this pull request
Sep 25, 2023
This updates each PO file to the date when it was last touched:
for po_file in po/*.po; do
POT_DATE=$(git log -1 --date=short --format=%ad $po_file)
sed -i -e 's/"POT-Creation-Date:.*"/"POT-Creation-Date: '$POT_DATE'\\n"/' $po_file
done
The dates will be updated with `msgmerge` in the future via
google/mdbook-i18n-helpers#87.
This was referenced Sep 25, 2023
mgeisler
added a commit
to google/comprehensive-rust
that referenced
this pull request
Sep 25, 2023
This updates each PO file to the date when it was last touched:
for po_file in po/*.po; do
POT_DATE=$(git log -1 --date=short --format=%ad $po_file)
sed -i -e 's/"POT-Creation-Date:.*"/"POT-Creation-Date:
'$POT_DATE'\\n"/' $po_file
done
The dates will be updated with `msgmerge` in the future via
google/mdbook-i18n-helpers#87.
The dates here can be adjusted by hand if needed — the starting point
here only serves as a rough anchor to let us freeze the translations
from further updates. So if you know that you ran `msgmerge` most
recently on a given date, please update the file to that date in a later
PR.
|
See google/comprehensive-rust#1243 for the other half of this: updating the the data in POT-Creation-Date when publishing a book. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data is added to PO files automatically by
msgmerge. This will in turn be used when publishing a translation: it allows us to know which sources goes into a given PO file.Part of #16.