Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show channel progress indicator if it's taking >500ms to avoid jarring UX #372

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

wwwillchen
Copy link
Collaborator

closes #365

@richard-to
Copy link
Collaborator

Yeah this is an interesting issue. I agree that on the on input it is can be feel jarring and visually makes Mesop feel slower. I often wait for the indicator to stop before I press submit. However, that's because I know it may not include all my text if I submit too early.

Especially for long running operations, I definitely think a good practice is to force disable other inputs. Otherwise you run the possibility of user's queuing up many actions and that can be weird. This can be a useful indicator that something is happening.

I haven't tested out how this feels (haven't tested out the branch), but I'll keep an eye on it when I'm testing out Mesop apps.

Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwillchen
Copy link
Collaborator Author

Yeah this is an interesting issue. I agree that on the on input it is can be feel jarring and visually makes Mesop feel slower. I often wait for the indicator to stop before I press submit. However, that's because I know it may not include all my text if I submit too early.

Especially for long running operations, I definitely think a good practice is to force disable other inputs. Otherwise you run the possibility of user's queuing up many actions and that can be weird. This can be a useful indicator that something is happening.

I haven't tested out how this feels (haven't tested out the branch), but I'll keep an eye on it when I'm testing out Mesop apps.

Yeah, makes sense. You should document that pattern of disabling other inputs in our docs :)

@wwwillchen wwwillchen merged commit f39429c into google:main Jun 7, 2024
3 checks passed
@wwwillchen wwwillchen deleted the i365 branch June 7, 2024 23:11
wwwillchen added a commit to wwwillchen/mesop that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debounce progress indicator
2 participants