Update is same site #386
Merged
Update is same site #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix ci issues
fixed indentation
new line EOF
urlparse(url) -> urlparse.urlparse
Exception -> ValueError
rm exception comment
rm use of typing.Optional as previous version was actually the preferred method as of python 3.10
|
Sorry this PR has been a bit messy |
|
thanks for contributing |
wwwillchen
pushed a commit
to wwwillchen/mesop
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the
is_same_siteFunctionConsolidation of Initial Checks:
The checks for whether
url1orurl2isNonehave been combined into a single line.