Allow flex-shrink to be set to 0.
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `flex-shrink` css property could not be set to 0 since Mesop will
ignore styles that are "empty".
Normally this is fine, but `flex-shrink` defaults to 1, which means the
"empty" state will make `flex-shrink` equal to 1. This means that 0
cannot be set for `flex-shrink`.
To resolve this, we can change the date type to a string in the UI
proto.
Example:
```
import mesop as me
@me.page(path="/flex_shrink")
def main():
with me.box(style=me.Style(display="flex", flex_shrink="0")):
me.text("Testing flex shrink")
```
|
Thanks for contributing! |
wwwillchen
pushed a commit
to wwwillchen/mesop
that referenced
this pull request
Apr 23, 2024
The `flex-shrink` css property could not be set to 0 since Mesop will
ignore styles that are "empty".
Normally this is fine, but `flex-shrink` defaults to 1, which means the
"empty" state will make `flex-shrink` equal to 1. This means that 0
cannot be set for `flex-shrink`.
To resolve this, we can change the data type to a string in the UI
proto.
Example:
```
import mesop as me
@me.page(path="/flex_shrink")
def main():
with me.box(style=me.Style(display="flex", flex_shrink="0")):
me.text("Testing flex shrink")
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flex-shrinkcss property could not be set to 0 since Mesop will ignore styles that are "empty".Normally this is fine, but
flex-shrinkdefaults to 1, which means the "empty" state will makeflex-shrinkequal to 1. This means that 0 cannot be set forflex-shrink.To resolve this, we can change the date type to a string in the UI proto.
Example:
Also here's a screenshot to check that the property is being set correctly:
Fixes #69