Log path changes in BaseTestClass.
#650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterfroststrom
previously approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @winterfroststrom and @xpconanfan)
mobly/base_test.py, line 97 at r1 (raw file):
self._class_name
no action needed for this, but we apparently have some internal users using this
* Add a new level of output directoy specific to test classes. * Direct `log_path` to class-specific. * Add a `root_output_path` pointing to the test run path (what `log_path` used to point to)
winterfroststrom
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseTestClass.log_pathandlogging.log_pathto class-specific output directory.root_output_pathpointing to the test run path (whatlog_pathused to point to)This change is