[WIP] Make AndroidDevice#build_info strictly returns a dict #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can update docstring and other things if we agree this change makes sense. |
xpconanfan
approved these changes
Jun 7, 2024
mhaoli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now AndroidDevice#build_info returns a None when in fastboot and a dict otherwise.
I'm not quite sure if we were intentionally returning a None when the device is in fastboot. But I think making it strictly return a dict looks more reliable. So users won't get errors like
"TypeError: 'NoneType' object is not subscriptable"
WDYT @xpconanfan ?
This change is