Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pre-launching mozc_server and mozc_renderer from mozc_tool.exe --mode=post_install_dialog in Windows #845

Closed
yukawa opened this issue Nov 14, 2023 · 0 comments

Comments

@yukawa
Copy link
Collaborator

yukawa commented Nov 14, 2023

Description

There has been a known limitation that processes like mozc_server and mozc_renderer cannot be launched from sandboxed processes such as SearchHost.exe in Windows. We have worked around this limitation by running mozc_broker.exe --mode=prelaunch_processes when the user logs in since Mozc 2.18.2602.102 (0488082).

<!--
Write a registry key to launch mozc_server.exe and
mozc_renderer.exe automatically after user logon.
-->
<Component Id='PrelaunchProcesses' Guid='*'>
<RegistryValue Id='RunBroker' Root='HKLM'
Key='Software\Microsoft\Windows\CurrentVersion\Run'
Name='Mozc Prelauncher' Action='write' Type='string'
Value='&quot;[MozcDir]mozc_broker.exe&quot; --mode=prelaunch_processes' />
</Component>

We, however, have not performed this workaround immediately after installing Mozc (and running mozc_tool.exe --mode=post_install_dialog).

As a result, the user may notice that they cannot use Mozc in the search field in the task bar immediately after installing Mozc.

Steps to reproduce

Steps to reproduce the behavior:

  1. Build and install Mozc for Windows
  2. "%ProgramFiles(x86)%\Mozc\mozc_tool.exe" --mode=post_install_dialog
  3. Click the "Search" field in the task bar
  4. Try to enable Mozc

Expected behavior

You can enable Mozc at the step 4.

Actual behavior

You cannot enable Mozc at the step 4.

Version or commit-id

6c920a9

Environment

  • OS: Windows 11 22H2
hiroyuki-komatsu added a commit that referenced this issue Nov 15, 2023
Typing quality
* Updated the word dictionary.
* Adjusted the conversion with suffix numbers (e.g. 後に vs あと2).

Windows
* Prelaunch processes from the installer (#845)

Build
* Updated the Protobuf version: v24.2 → v25.0 (#841)
* Updated the Abseil version: 20230125.3 → 20230802.1 (#841)
* Supported to follow updates of external environmental dependencies (#843, #844)
* Removed `third_party/ipa_font` and introduced our own testing font  (#842)
* Android: Fixed the linkage error of Android library build (#840)

PiperOrigin-RevId: 582509744
coooooooozy pushed a commit to coooooooozy/mozc that referenced this issue Nov 26, 2023
This is a follow up to my previous commit [1], which started executing
the following command

 mozc_broker --mode=prelaunch_processes

to pre-launch 'mozc_server' and 'mozc_renderer' whenever the user logs
in on Windows because these processes cannot be launched from sandboxed
processes such as 'SearchHost.exe'.

With this commit, effectively the same workaround will be performed
after installing Mozc and while executing post install dialog.

Closes google#845.

 [1]: 0488082

PiperOrigin-RevId: 582383447
coooooooozy pushed a commit to coooooooozy/mozc that referenced this issue Nov 26, 2023
Typing quality
* Updated the word dictionary.
* Adjusted the conversion with suffix numbers (e.g. 後に vs あと2).

Windows
* Prelaunch processes from the installer (google#845)

Build
* Updated the Protobuf version: v24.2 → v25.0 (google#841)
* Updated the Abseil version: 20230125.3 → 20230802.1 (google#841)
* Supported to follow updates of external environmental dependencies (google#843, google#844)
* Removed `third_party/ipa_font` and introduced our own testing font  (google#842)
* Android: Fixed the linkage error of Android library build (google#840)

PiperOrigin-RevId: 582509744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant