Consider specifying configure = True when using repository_rule

[yukawa]

Description

Currently pkg_config_repository, qt_mac_repository.bzl, and android_repository use repository_rule without configure = True.

If the configure flag is set, the repository is only re-fetched on bazel sync when the --configure parameter is passed to it (if the attribute is unset, this command will not cause a re-fetch)

As a result, these repositories will not be re-evaluated upon bazel sync --configure.

pkg_config_repository

mozc/src/bazel/pkg_config_repository.bzl

Lines 117 to 122 in e324bf2

	pkg_config_repository = repository_rule(
	implementation = _pkg_config_repository_impl,
	attrs = {
	"packages": attr.string_list(),
	},
	)

mozc/src/WORKSPACE.bazel

Lines 119 to 123 in e324bf2

	# iBus
	pkg_config_repository(
	name = "ibus",
	packages = ["glib-2.0", "gobject-2.0", "ibus-1.0"],
	)

mozc/src/WORKSPACE.bazel

Lines 132 to 136 in e324bf2

	# Qt for Linux
	pkg_config_repository(
	name = "qt_linux",
	packages = ["Qt6Core", "Qt6Gui", "Qt6Widgets"],
	)

qt_mac_repository.bzl

mozc/src/bazel/qt_mac_repository.bzl

Lines 44 to 50 in e324bf2

	qt_mac_repository = repository_rule(
	implementation = _qt_mac_repository_impl,
	environ = ["MOZC_QT_PATH"],
	attrs = {
	"default_path": attr.string(),
	},
	)

android_repository

mozc/src/bazel/android_repository.bzl

Lines 63 to 66 in e324bf2

	android_repository = repository_rule(
	implementation = _android_repository_impl,
	environ = ["ANDROID_NDK_HOME"],
	)

Steps to reproduce

1. Install Ubuntu 23.10 server as a minimum installation
2. Run the following commands.

sudo apt-get install -y curl gnupg libncurses6
curl -fsSL https://bazel.build/bazel-release.pub.gpg | gpg --dearmor > bazel.gpg
sudo mv bazel.gpg /etc/apt/trusted.gpg.d/
echo "deb [arch=amd64] https://storage.googleapis.com/bazel-apt stable jdk1.8" | sudo tee /etc/apt/sources.list.d/bazel.list
sudo apt-get update
sudo apt-get install -y git build-essential python3 bazel pkg-config
git clone https://github.com/google/mozc.git -b master --single-branch --recursive
cd mozc/src
bazel build package --config oss_linux -c opt

3. Then run the following commands.

sudo apt-get install -y libibus-1.0-dev libglib2.0-dev qt6-base-dev libgl-dev
bazel sync --configure
bazel build package --config oss_linux -c opt

Expected behavior

• At the step 2, the build fails due to missing dependencies (libibus-1.0-dev, libglib2.0-dev, qt6-base-dev, libgl-dev)
• At the step 3, the build succeeds.

Actual behavior

• At the step 2, the build fails due to missing dependencies (libibus-1.0-dev, libglib2.0-dev, qt6-base-dev, libgl-dev)
• At the step 3, the build fails with the same error as the step 2.

Version or commit-id

e324bf2

Environment

• OS: Ubuntu 23.10