Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodules: protobuf to v25.0 and abseil-cpp to 20230802.1 LTS #841

Closed
yukawa opened this issue Nov 2, 2023 · 1 comment
Closed

Comments

@yukawa
Copy link
Collaborator

yukawa commented Nov 2, 2023

Description

Protocol Buffers v25.0 is released. It uses abseil-cpp 20230802.1 LTS as their official build configuration.

Let's update our build dependencies as well.

Version or commit-id

ddd9730

Environment

  • OS: All
@yukawa yukawa pinned this issue Nov 2, 2023
hiroyuki-komatsu pushed a commit that referenced this issue Nov 6, 2023
This is a preparation to update Protobuf to v25.0 (#841).

With this commit, protobuf.gyp becomes compatible with both v24.2 and
v25.0.

Note that Protobuf version is not yet updated in this commit.
Thus there must be no observable behavior change.

PiperOrigin-RevId: 579739765
@yukawa
Copy link
Collaborator Author

yukawa commented Nov 14, 2023

Completed with d40930d and 6c920a9.

@yukawa yukawa closed this as completed Nov 14, 2023
hiroyuki-komatsu added a commit that referenced this issue Nov 15, 2023
Typing quality
* Updated the word dictionary.
* Adjusted the conversion with suffix numbers (e.g. 後に vs あと2).

Windows
* Prelaunch processes from the installer (#845)

Build
* Updated the Protobuf version: v24.2 → v25.0 (#841)
* Updated the Abseil version: 20230125.3 → 20230802.1 (#841)
* Supported to follow updates of external environmental dependencies (#843, #844)
* Removed `third_party/ipa_font` and introduced our own testing font  (#842)
* Android: Fixed the linkage error of Android library build (#840)

PiperOrigin-RevId: 582509744
coooooooozy pushed a commit to coooooooozy/mozc that referenced this issue Nov 26, 2023
This is a preparation to update Protobuf to v25.0 (google#841).

With this commit, protobuf.gyp becomes compatible with both v24.2 and
v25.0.

Note that Protobuf version is not yet updated in this commit.
Thus there must be no observable behavior change.

PiperOrigin-RevId: 579739765
coooooooozy pushed a commit to coooooooozy/mozc that referenced this issue Nov 26, 2023
Typing quality
* Updated the word dictionary.
* Adjusted the conversion with suffix numbers (e.g. 後に vs あと2).

Windows
* Prelaunch processes from the installer (google#845)

Build
* Updated the Protobuf version: v24.2 → v25.0 (google#841)
* Updated the Abseil version: 20230125.3 → 20230802.1 (google#841)
* Supported to follow updates of external environmental dependencies (google#843, google#844)
* Removed `third_party/ipa_font` and introduced our own testing font  (google#842)
* Android: Fixed the linkage error of Android library build (google#840)

PiperOrigin-RevId: 582509744
@yukawa yukawa unpinned this issue Jan 16, 2024
hiroyuki-komatsu pushed a commit that referenced this issue Mar 16, 2024
This is a follow up commit to my previous commit [1] for #841, which
made protobuf.gyp compatible with Protobuf v25.0 to work around a
compile error [2].

Now that Mozc has switched to Protobuf v26.0 [3] (#871), this work
around is no longer necessary.

 [1]: 013e8aa
 [2]: protocolbuffers/protobuf#14602
 [3]: 0df12d0

#codehealth

PiperOrigin-RevId: 616344978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant