-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric size limits to the language and metric store. #645
Conversation
…tric. Call this from the Store GC method as many times as necessary to get a metric down to its limit. Fixes #617
Codecov Report
@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 56.44% 56.82% +0.38%
==========================================
Files 66 66
Lines 7360 7400 +40
==========================================
+ Hits 4154 4205 +51
+ Misses 2955 2943 -12
- Partials 251 252 +1
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Benchmark ResultBenchmark diff with base
|
Unit Test Results 1 files 27 suites 2m 58s ⏱️ Results for commit 4895acf. |
The new keyword
limit
on a metric declaration specifies a storage size limit on simultaneous label values; if the metric exceeds that size then the next GC run will remove the oldest by timestamp until it is back under the limit.Fixes #617