increase msg_control buffer size #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes malformed vec when recvmsg buffer_size is too large
wdebruij
approved these changes
Feb 9, 2024
| @@ -303,7 +303,7 @@ int tcpd_recv(int socket, void *f_mbuf, size_t n, int flags, struct thread *t) { | |||
| client_fd = socket; | |||
|
|
|||
| char buf_dummy[n]; | |||
| char offsetbuf[CMSG_SPACE(sizeof(int) * 1000)]; | |||
| char offsetbuf[CMSG_SPACE(sizeof(iov) * 10000)]; | |||
There was a problem hiding this comment.
Fairly large for stack allocation. But for userspace stacks, I suppose it's okay.
|
looks good to me. |
gfantom
added a commit
that referenced
this pull request
Jun 25, 2024
increase msg_control buffer size
gfantom
added a commit
that referenced
this pull request
Jun 25, 2024
increase msg_control buffer size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes malformed vec when recvmsg buffer_size is too large