-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies esp. antlr+jcommander #2550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @CydeWeys and @gbrodman)
dependencies.gradle
line 87 at r1 (raw file):
Previously, gbrodman wrote…
it's in the 2.x versions, it parses arguments where the type is
Set<String>
differently -- I didn't do enough digging to figure out what would be necessary to fix it
I'm looking into this, for now locking to 1.83 is the fastest way to unlock upgrading other dependencies.
dependencies.gradle
line 91 at r1 (raw file):
// There are breaking changes in the 4.x range of antlr so we need to make sure we don't // pick up any older versions from transitive dependencies 'org.antlr:antlr4:4.13.2',
It seems like you only need to make sure they are both [4.13.2, ), right? It is currently the latest version, and you want to makes sure the versions between compile time and runtime dependencies match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 18 of 19 files reviewed, 2 unresolved discussions (waiting on @CydeWeys and @jianglai)
dependencies.gradle
line 91 at r1 (raw file):
Previously, jianglai (Lai Jiang) wrote…
It seems like you only need to make sure they are both [4.13.2, ), right? It is currently the latest version, and you want to makes sure the versions between compile time and runtime dependencies match.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @CydeWeys)
This change is