Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

novm {create, run} can not work with go 1.3 and 1.4 #23

Closed
hamo opened this issue Jan 14, 2015 · 3 comments
Closed

novm {create, run} can not work with go 1.3 and 1.4 #23

hamo opened this issue Jan 14, 2015 · 3 comments

Comments

@hamo
Copy link
Contributor

hamo commented Jan 14, 2015

tried with binary built with go 1.2, 1.3 and 1.4. With go 1.3 and 1.4, novm run command and novm create command will hang, can not show the result from command. It works with go 1.2 compiled binary.
@amscanne
Copy link
Contributor

Hm, this is very interesting and may explain a lot. Thanks for the report. I'll dig into this as soon as a have a chance.

@pwaller
Copy link

pwaller commented Jan 27, 2015

I think #7 and #10 are likely explained by this. I tried go 1.2 and it works much better.

amscanne added a commit to amscanne/novm that referenced this issue Feb 3, 2015
@amscanne
Fix go1.3 and go1.4 compatibility issue.
2965007 
The garbage collector was cleaning up the console file. We lift it out
of the if scope, and noguest works again.

This should fix google#7, google#10 and google#23.
@amscanne
Copy link
Contributor

amscanne commented Feb 3, 2015

I hope that 2965007 fixes this issue. I've verified locally, but please reopen if you find otherwise.

@amscanne amscanne closed this as completed Feb 3, 2015
This was referenced Feb 3, 2015
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hamo @amscanne @pwaller